-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract block issuer from node in tests and components #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feat/block-issuer-tests
alexsporn
reviewed
Oct 5, 2023
alexsporn
reviewed
Oct 6, 2023
alexsporn
reviewed
Oct 6, 2023
alexsporn
reviewed
Oct 6, 2023
alexsporn
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the blockfactory package with a the blockhandler package, which simply accepts pre-signed blocks but does not modify them or create new ones.
We also add a blockissuer module to the mock package of the testsuite which is mostly copied over from the blockfactory package, and we extract this blockissuer module from the mock node in the tests. Validator nodes still own a block issuer for issuing their validation blocks only, but for any other block issuance, an external block issuer must be used in all tests now. This functionality will later be extended to include a more complete user/wallet style interaction in the tests to more accurately reflect the user/node flow rather than the entirely node-centric testing prior to this PR.