Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract block issuer from node in tests and components #400

Merged
merged 17 commits into from
Oct 9, 2023

Conversation

cyberphysic4l
Copy link
Contributor

@cyberphysic4l cyberphysic4l commented Oct 4, 2023

This PR replaces the blockfactory package with a the blockhandler package, which simply accepts pre-signed blocks but does not modify them or create new ones.

We also add a blockissuer module to the mock package of the testsuite which is mostly copied over from the blockfactory package, and we extract this blockissuer module from the mock node in the tests. Validator nodes still own a block issuer for issuing their validation blocks only, but for any other block issuance, an external block issuer must be used in all tests now. This functionality will later be extended to include a more complete user/wallet style interaction in the tests to more accurately reflect the user/node flow rather than the entirely node-centric testing prior to this PR.

@cyberphysic4l cyberphysic4l merged commit e93e442 into develop Oct 9, 2023
4 checks passed
@cyberphysic4l cyberphysic4l deleted the feat/block-issuer-tests branch October 9, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants